netdev - Re: [net-next 0/6] net: wwan: t7xx: fw flashing & coredump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMtyV8qxr4RePrgb@nanopsycho>
Date: Thu, 3 Aug 2023 11:24:39 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
	johannes@...solutions.net, ryazanov.s.a@...il.com,
	loic.poulain@...aro.org, ilpo.jarvinen@...ux.intel.com,
	ricardo.martinez@...ux.intel.com,
	chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
	edumazet@...gle.com, pabeni@...hat.com,
	chandrashekar.devegowda@...el.com, m.chetan.kumar@...ux.intel.com,
	linuxwwan@...el.com, linuxwwan_5g@...el.com,
	soumya.prakash.mishra@...el.com, jesse.brandeburg@...el.com,
	danielwinkler@...gle.com, Jinjian Song <jinjian.song@...ocom.com>
Subject: Re: [net-next 0/6] net: wwan: t7xx: fw flashing & coredump support

Thu, Aug 03, 2023 at 04:18:06AM CEST, songjinjian@...mail.com wrote:
>From: Jinjian Song <jinjian.song@...ocom.com>
>
>Adds support for t7xx wwan device firmware flashing & coredump collection
>using devlink.
>
>On early detection of wwan device in fastboot mode driver sets up CLDMA0 HW
>tx/rx queues for raw data transfer and then registers to devlink framework.
>On user space application issuing command for firmware update the driver
>sends fastboot flash command & firmware to program NAND.
>
>In flashing procedure the fastboot command & response are exchanged between
>driver and device. Once firmware flashing is success, user space application
>get modem event by sysfs interface.
>
>Below is the devlink command usage for firmware flashing
>
>$devlink dev flash pci/$BDF file ABC.img component ABC
>
>Note: ABC.img is the firmware to be programmed to "ABC" partition.
>
>In case of coredump collection when wwan device encounters an exception
>it reboots & stays in fastboot mode for coredump collection by host driver.
>On detecting exception state driver collects the core dump, creates the
>devlink region & reports an event to user space application for dump
>collection. The user space application invokes devlink region read command
>for dump collection.
>
>Below are the devlink commands used for coredump collection.
>
>devlink region new pci/$BDF/mr_dump
>devlink region read pci/$BDF/mr_dump snapshot $ID address $ADD length $LEN
>devlink region del pci/$BDF/mr_dump snapshot $ID

Interesting. Makes me wonder why you didn't mention the "fastboot" param
in the cover letter...


>
>Jinjian Song (6):
>  net: wwan: t7xx: Infrastructure for early port configuration
>  net: wwan: t7xx: Driver registers with Devlink framework
>  net: wwan: t7xx: Implements devlink ops of firmware flashing
>  net: wwan: t7xx: Creates region & snapshot for coredump log collection
>  net: wwan: t7xx: Adds sysfs attribute of modem event
>  net: wwan: t7xx: Devlink documentation
>
> Documentation/networking/devlink/index.rst |   1 +
> Documentation/networking/devlink/t7xx.rst  | 232 +++++++
> drivers/net/wwan/Kconfig                   |   1 +
> drivers/net/wwan/t7xx/Makefile             |   4 +-
> drivers/net/wwan/t7xx/t7xx_hif_cldma.c     |  47 +-
> drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  18 +-
> drivers/net/wwan/t7xx/t7xx_modem_ops.c     |   5 +-
> drivers/net/wwan/t7xx/t7xx_pci.c           |  79 ++-
> drivers/net/wwan/t7xx/t7xx_pci.h           |  19 +
> drivers/net/wwan/t7xx/t7xx_port.h          |   6 +
> drivers/net/wwan/t7xx/t7xx_port_ap_msg.c   |  78 +++
> drivers/net/wwan/t7xx/t7xx_port_ap_msg.h   |  11 +
> drivers/net/wwan/t7xx/t7xx_port_devlink.c  | 723 +++++++++++++++++++++
> drivers/net/wwan/t7xx/t7xx_port_devlink.h  |  85 +++
> drivers/net/wwan/t7xx/t7xx_port_proxy.c    | 118 +++-
> drivers/net/wwan/t7xx/t7xx_port_proxy.h    |  14 +
> drivers/net/wwan/t7xx/t7xx_port_wwan.c     |  27 +-
> drivers/net/wwan/t7xx/t7xx_reg.h           |  28 +-
> drivers/net/wwan/t7xx/t7xx_state_monitor.c | 137 +++-
> drivers/net/wwan/t7xx/t7xx_state_monitor.h |   1 +
> 20 files changed, 1556 insertions(+), 78 deletions(-)
> create mode 100644 Documentation/networking/devlink/t7xx.rst
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.c
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.h
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.c
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.h
>
>-- 
>2.34.1
>
>