netdev - Re: [net-next 2/6] net: wwan: t7xx: Driver registers with Devlink framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMt6ZZxIHMrml0+E@nanopsycho>
Date: Thu, 3 Aug 2023 11:59:01 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
	johannes@...solutions.net, ryazanov.s.a@...il.com,
	loic.poulain@...aro.org, ilpo.jarvinen@...ux.intel.com,
	ricardo.martinez@...ux.intel.com,
	chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
	edumazet@...gle.com, pabeni@...hat.com,
	chandrashekar.devegowda@...el.com, m.chetan.kumar@...ux.intel.com,
	linuxwwan@...el.com, linuxwwan_5g@...el.com,
	soumya.prakash.mishra@...el.com, jesse.brandeburg@...el.com,
	danielwinkler@...gle.com, Jinjian Song <jinjian.song@...ocom.com>
Subject: Re: [net-next 2/6] net: wwan: t7xx: Driver registers with Devlink
 framework

Thu, Aug 03, 2023 at 04:18:08AM CEST, songjinjian@...mail.com wrote:

[...]

>+static const struct devlink_param t7xx_devlink_params[] = {
>+	DEVLINK_PARAM_DRIVER(T7XX_DEVLINK_PARAM_ID_FASTBOOT,
>+			     "fastboot", DEVLINK_PARAM_TYPE_BOOL,
>+			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
>+			     NULL, NULL, NULL),

driver init params is there so the user could configure driver instance
and then hit devlink reload in order to reinitialize with the new param
values. In your case, it is a device command. Does not make any sense to
have it as param.

NAK