netdev - Re: [PATCH bpf-next v2 3/3] net: invert the netdevice.h vs xdp.h dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bac02af2-755c-a338-52f1-35ae51841b9f@kernel.org>
Date: Thu, 3 Aug 2023 15:59:54 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, amritha.nambiar@...el.com,
 aleksander.lobakin@...el.com, daniel@...earbox.net,
 john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
 song@...nel.org, yonghong.song@...ux.dev, ast@...nel.org,
 kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org
Subject: Re: [PATCH bpf-next v2 3/3] net: invert the netdevice.h vs xdp.h
 dependency



On 03/08/2023 03.02, Jakub Kicinski wrote:
> xdp.h is far more specific and is included in only 67 other
> files vs netdevice.h's 1538 include sites.
> Make xdp.h include netdevice.h, instead of the other way around.
> This decreases the incremental allmodconfig builds size when
> xdp.h is touched from 5947 to 662 objects.
> 
> Move bpf_prog_run_xdp() to xdp.h, seems appropriate and filter.h
> is a mega-header in its own right so it's nice to avoid xdp.h
> getting included there as well.
> 
> The only unfortunate part is that the typedef for xdp_features_t
> has to move to netdevice.h, since its embedded in struct netdevice.
> 
> Signed-off-by: Jakub Kicinski<kuba@...nel.org>
> ---
> CC:ast@...nel.org
> CC:daniel@...earbox.net
> CC:john.fastabend@...il.com
> CC:andrii@...nel.org
> CC:martin.lau@...ux.dev
> CC:song@...nel.org
> CC:yonghong.song@...ux.dev
> CC:kpsingh@...nel.org
> CC:sdf@...gle.com
> CC:haoluo@...gle.com
> CC:jolsa@...nel.org
> CC:hawk@...nel.org
> CC:bpf@...r.kernel.org
> ---
>   include/linux/filter.h           | 17 -----------------
>   include/linux/netdevice.h        | 11 ++++-------
>   include/net/busy_poll.h          |  1 +
>   include/net/xdp.h                | 29 +++++++++++++++++++++++++----
>   include/trace/events/xdp.h       |  1 +
>   kernel/bpf/btf.c                 |  1 +
>   kernel/bpf/offload.c             |  1 +
>   kernel/bpf/verifier.c            |  1 +
>   net/netfilter/nf_conntrack_bpf.c |  1 +
>   9 files changed, 35 insertions(+), 28 deletions(-)

LGTM

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>