netdev - Re: [PATCH] wifi: iw_handler.h: Remove unused declaration dev_get_wireless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMvr2lNVTPLqs8Nq@kernel.org>
Date: Thu, 3 Aug 2023 20:03:06 +0200
From: Simon Horman <horms@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: johannes@...solutions.net, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: iw_handler.h: Remove unused declaration
 dev_get_wireless_info()

On Thu, Aug 03, 2023 at 09:42:48PM +0800, Yue Haibing wrote:
> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211")
> declared but never implemented this, remove it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  include/net/iw_handler.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h
> index d2ea5863eedc..99f46f521aa7 100644
> --- a/include/net/iw_handler.h
> +++ b/include/net/iw_handler.h
> @@ -432,9 +432,6 @@ struct iw_public_data {
>  
>  /* First : function strictly used inside the kernel */
>  

Hi Yue Haibing,

I think you can remove the comment above and blank line below it too.

> -/* Handle /proc/net/wireless, called in net/code/dev.c */
> -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length);
> -
>  /* Second : functions that may be called by driver modules */

And work this into the comment above the to be deleted 'First :' comment.
Something like this:

/*
 * Functions part of the Wireless Extensions (defined in net/core/wireless.c).
 * These may be called by driver modules.
 */ 

>  
>  /* Send a single event to user space */
> -- 
> 2.34.1
> 
>