Message-ID: <ZMv2rC8CACihovLl@shell.armlinux.org.uk>
Date: Thu, 3 Aug 2023 19:49:16 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Ioana Ciornei <ciorneiioana@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>,
	Alexandru Ardelean <alexandru.ardelean@...log.com>,
	Andre Edich <andre.edich@...rochip.com>,
	Antoine Tenart <atenart@...nel.org>,
	Baruch Siach <baruch@...s.co.il>,
	Christophe Leroy <christophe.leroy@....fr>,
	Divya Koppera <Divya.Koppera@...rochip.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Jerome Brunet <jbrunet@...libre.com>,
	Kavya Sree Kotagiri <kavyasree.kotagiri@...rochip.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Marco Felsch <m.felsch@...gutronix.de>, Marek Vasut <marex@...x.de>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Mathias Kresin <dev@...sin.me>, Maxim Kochetkov <fido_max@...ox.ru>,
	Michael Walle <michael@...le.cc>,
	Neil Armstrong <narmstrong@...libre.com>,
	Nisar Sayed <Nisar.Sayed@...rochip.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Philippe Schenker <philippe.schenker@...adex.com>,
	Willy Liu <willy.liu@...ltek.com>,
	Yuiko Oshino <yuiko.oshino@...rochip.com>
Subject: Re: [PATCH net-next v2 02/19] net: phy: add a shutdown procedure

On Thu, Aug 03, 2023 at 11:24:04AM -0700, Florian Fainelli wrote:
> On 8/3/23 11:16, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this patch became commit e2f016cf775129c050d6c79483073423db15c79a and is
> > contained in v5.11-rc1.
> > 
> > It broke wake-on-lan on my NAS (an ARM machine with an Armada 370 SoC,
> > armada-370-netgear-rn104.dts). The used phy driver is marvell.c. I only
> > report it now as I just upgraded that machine from Debian 11 (with
> > kernel 5.10.x) to Debian 12 (with kernel 6.1.x).
> > 
> > Commenting out phy_disable_interrupts(...) in v6.1.41's phy_shutdown()
> > fixes the problem for me.
> > 
> > On Sun, Nov 01, 2020 at 02:50:57PM +0200, Ioana Ciornei wrote:
> > > In case of a board which uses a shared IRQ we can easily end up with an
> > > IRQ storm after a forced reboot.
> > > 
> > > For example, a 'reboot -f' will trigger a call to the .shutdown()
> > > callbacks of all devices. Because phylib does not implement that hook,
> > > the PHY is not quiesced, thus it can very well leave its IRQ enabled.
> > > 
> > > At the next boot, if that IRQ line is found asserted by the first PHY
> > > driver that uses it, but _before_ the driver that is _actually_ keeping
> > > the shared IRQ asserted is probed, the IRQ is not going to be
> > > acknowledged, thus it will keep being fired preventing the boot process
> > > of the kernel to continue. This is even worse when the second PHY driver
> > > is a module.
> > > 
> > > To fix this, implement the .shutdown() callback and disable the
> > > interrupts if these are used.
> > 
> > I don't know how this should interact with wake-on-lan, but I would
> > expect that there is a way to fix this without reintroducing the problem
> > fixed by this change. However I cannot say if this needs fixing in the
> > generic phy code or the phy driver. Any hints?
> 
> It depends upon what the PHY drivers and underlying hardware are capable and
> willing to do. Some PHY drivers will shutdown the TX path completely since
> you do not need that part to receive Wake-on-LAN packets and pass them up to
> the PHY and/or MAC Wake-on-LAN matching logic. This would invite us to let
> individual PHY drivers make a decision as to what they want to do in a
> .shutdown() routine that would then need to be added to each and every
> driver that wants to do something special. In the absence of said routine,
> you could default to calling phy_disable_interrupts() unless the PHY has WoL
> enabled?
> 
> phydev::wol_enabled reflects whether the PHY and/or the MAC has Wake-on-LAN
> enabled which could you could key off to "nullify" what the shutdown does.

If the shutdown method is being called, doesn't that imply that we're
going to be hibernating rather than suspend-to-RAM - because suspend-to
RAM doesn't involve powering down the system, whereas hibernating does.

I think the problem is that when placing the system into hibernate mode
with WoL enabled, there are PHYs which use their interrupt pin to signal
that a WoL event has happened. The problem comes with the aforementioned
commit that the core PHY code now _always_ disables interrupts on the
PHY, even if WoL is active and we're entering hibernate mode.

That's clearly the wrong thing to be doing when people expect WoL to
be able to wake their systems up from hibernate.

The more I think about it, the more I'm coming to the conclusion that
the blamed commit is wrong as it is coded today.

It also occurs to me that systems need to cope with the PHY's INT signal
being asserted through boot, because in the case of WoL-triggered resume
from hibernate mode, the PHY's INT signal will be asserted _while_ the
system is booting up (and remember, recovery from hibernate mode is
essentially no different from a normal system boot with the exception
that the kernel notices a special signature in the swap partition, and
then reloads state from there.)

So, boot has to cope properly with the PHY's interrupt being asserted
in order for WoL from hibernate to work.

It seems to me that a revert of the blamed commit is in order, and a
different approach is needed?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Powered by blists - more mailing lists