netdev - Re: [PATCH net-next 5/7] ice: Add get C827 PHY index function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230802192827.6fdf36ae@kernel.org>
Date: Wed, 2 Aug 2023 19:28:27 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, Karol Kolacinski <karol.kolacinski@...el.com>,
 Michal Michalik <michal.michalik@...el.com>, Jan Sokolowski
 <jan.sokolowski@...el.com>, Pucha Himasekhar Reddy
 <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 5/7] ice: Add get C827 PHY index function

On Tue,  1 Aug 2023 10:31:10 -0700 Tony Nguyen wrote:
> +bool ice_is_pf_c827(struct ice_hw *hw);
>  int ice_init_hw(struct ice_hw *hw);
>  void ice_deinit_hw(struct ice_hw *hw);
>  int ice_check_reset(struct ice_hw *hw);
> @@ -94,6 +95,10 @@ ice_aq_get_phy_caps(struct ice_port_info *pi, bool qual_mods, u8 report_mode,
>  		    struct ice_aqc_get_phy_caps_data *caps,
>  		    struct ice_sq_cd *cd);
>  int
> +ice_aq_get_netlist_node(struct ice_hw *hw, struct ice_aqc_get_link_topo *cmd,
> +			u8 *node_part_number, u16 *node_handle);

doesn't seem like this one needs to be declared in the header?

> +bool ice_is_pf_c827(struct ice_hw *hw);

and this one is declared twice