netdev - RE: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR11MB3341C4078B29FBF86F14F8D5EC08A@SN6PR11MB3341.namprd11.prod.outlook.com>
Date: Thu, 3 Aug 2023 03:41:57 +0000
From: <VishvambarPanth.S@...rochip.com>
To: <vadim.fedorenko@...ux.dev>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: <Bryan.Whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <richardcochran@...il.com>
Subject: RE: [PATCH net-next] net: lan743x: skip timestamping for non-PTP
 packets

Hi Vadim,

Thanks for your review comments.
We will work on configuring timestamp based on hwtstamp_config. We will update in the next patch submission. 

Thanks,
Vishvambar Panth S

-----Original Message-----
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev> 
Sent: Monday, July 31, 2023 7:16 PM
To: VishvambarPanth S - I69108 <VishvambarPanth.S@...rochip.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
Cc: Bryan Whitehead - C21958 <Bryan.Whitehead@...rochip.com>; UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; richardcochran@...il.com
Subject: Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On 31/07/2023 13:54, Vishvambar Panth S wrote:
> Currently all the RX packets are timestamped and the timestamp is 
> appended to the RX packet for processing, this reduces RX throughput. 
> This can be optimized by timestamping packets only when the PTP messages are received.
> The RX PTP Configuration register [PTP_RX_TS_CFG] specifies what are 
> the PTP message types to be timestamped. The PTP_RX_TS_CFG_MSG_EN_ 
> configures Sync, Delay_Req, Pdelay_Req, Pdelay_Resp Message types to be timestamped.
> The RX_CFG_B_TS_ALL_RX_ bit enables storing the timestamp for all RX 
> frames, now this is cleared as only PTP packets will be timestamped. 
> The RX_CFG_B_TS_DESCR_EN_ enables storing the timestamp in an 
> extension descriptor. When PTP messages are received the timestamp 
> will be stored in an extension descriptor of the RX packet.

Even though the performance benefit is clear, the PTP subsystem provides options to select whether PTP filters must be applied or all packets must be stamped. I think it's better to implement both options as the hardware supports them, there are use cases where timestamps are needed for all packets. Linuxptp can be easily configured for both variants, the hardware/driver documentation can state that there will be performance degradation for all RX packets timestamps mode.