netdev - Re: [PATCH net-next v5 1/2] net/ipv6: Remove expired routes with a separated list of routes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efe86f7b-ae82-e3cd-f160-3d9ee0bfa05c@gmail.com>
Date: Wed, 2 Aug 2023 21:19:22 -0700
From: Kui-Feng Lee <sinquersw@...il.com>
To: David Ahern <dsahern@...nel.org>, thinker.li@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, martin.lau@...ux.dev,
 kernel-team@...a.com, yhs@...a.com
Cc: kuifeng@...a.com
Subject: Re: [PATCH net-next v5 1/2] net/ipv6: Remove expired routes with a
 separated list of routes.

On 8/2/23 19:00, David Ahern wrote:
> On 8/1/23 6:43 PM, thinker.li@...il.com wrote:
>> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
>> index bac768d36cc1..3059e439817a 100644
>> --- a/net/ipv6/ip6_fib.c
>> +++ b/net/ipv6/ip6_fib.c
>> @@ -1480,6 +1488,9 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
>>   			list_add(&rt->nh_list, &rt->nh->f6i_list);
>>   		__fib6_update_sernum_upto_root(rt, fib6_new_sernum(info->nl_net));
>>   		fib6_start_gc(info->nl_net, rt);
>> +
>> +		if (fib6_has_expires(rt))
>> +			hlist_add_head(&rt->gc_link, &table->tb6_gc_hlist);
> 
> This should go before the start_gc.
Agree