netdev - Re: [PATCH net-next 1/2] eth: bnxt: fix one of the W=1 warnings about fortified memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31a6821b-1eb0-abf9-6ede-549b158e8232@embeddedor.com>
Date: Thu, 3 Aug 2023 14:11:28 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
 netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next 1/2] eth: bnxt: fix one of the W=1 warnings about
 fortified memcpy()

On 8/3/23 14:04, Michael Chan wrote:
> On Thu, Aug 3, 2023 at 12:58 PM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>>
>>
>> On 8/3/23 08:46, Michael Chan wrote:
>>>
>>> The way I plan to fix this is to change the auto-generated struct
>>> hwrm_queue_cos2bw_qcfg_output to have an array of substruct.  I think
>>> that will look the cleanest.  I'll post it later today or tomorrow.
>>
>> Will that also fix the -Wstringop-overflow warning I mentioned in my
>> previous reply?
>>
>> drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:133:17: warning: writing 12 bytes into a region of size 1 [-Wstringop-overflow=]
>>
> 
> Yes, I will fix the other similar struct hwrm_queue_cos2bw_cfg_input
> in a similar way with an array of substruct.  Thanks.

Awesome! :)

Thank you
--
Gustavo