netdev - Re: [PATCH net-next 0/2] team: change return value of init and getter in the team

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMzkgSQTDVhRe18v@nanopsycho>
Date: Fri, 4 Aug 2023 13:44:01 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next 0/2] team: change return value of init and
 getter in the team_option structure to void

Fri, Aug 04, 2023 at 01:28:23PM CEST, shaozhengchao@...wei.com wrote:
>Because the init and getter function always returns 0, so change return
>value of init and getter in the team_option structure to void and remove
>redundant code.

Reading this 5 times, I don't understand the sentence :/

Also, why you send 2 patchsets and 2 seperate patches, all for team? Why
don't you send it as one 6-patch patchset?


>
>Zhengchao Shao (2):
>  team: change return value of init in the team_option structure to void
>  team: change return value of getter in the team_option structure to
>    void
>
> drivers/net/team/team.c                   | 60 +++++++++--------------
> drivers/net/team/team_mode_activebackup.c |  8 ++-
> drivers/net/team/team_mode_loadbalance.c  | 39 ++++++---------
> include/linux/if_team.h                   |  4 +-
> 4 files changed, 44 insertions(+), 67 deletions(-)
>
>-- 
>2.34.1
>