netdev - Re: [PATCH net-next] tcp/dccp: cache line align inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKhp6ghj6-+n9RXvP-Bc33kOdSMSTM1KQj=WSQ2DhgPWQ@mail.gmail.com>
Date: Fri, 4 Aug 2023 22:33:20 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: patchwork-bot+netdevbpf@...nel.org, Martin KaFai Lau <kafai@...com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp/dccp: cache line align inet_hashinfo

On Fri, Aug 4, 2023 at 10:30 AM <patchwork-bot+netdevbpf@...nel.org> wrote:
>
> Hello:
>
> This patch was applied to netdev/net-next.git (main)
> by David S. Miller <davem@...emloft.net>:
>
> On Thu,  3 Aug 2023 07:53:34 +0000 you wrote:
> > I have seen tcp_hashinfo starting at a non optimal location,
> > forcing input handlers to pull two cache lines instead of one,
> > and sharing a cache line that was dirtied more than necessary:
> >
> > ffffffff83680600 b tcp_orphan_timer
> > ffffffff83680628 b tcp_orphan_cache
> > ffffffff8368062c b tcp_enable_tx_delay.__tcp_tx_delay_enabled
> > ffffffff83680630 B tcp_hashinfo
> > ffffffff83680680 b tcp_cong_list_lock
> >
> > [...]
>
> Here is the summary with links:
>   - [net-next] tcp/dccp: cache line align inet_hashinfo
>     https://git.kernel.org/netdev/net-next/c/6f5ca184cbef
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>

Thanks !

Apparently this misalignment came with

commit cae3873c5b3a4fcd9706fb461ff4e91bdf1f0120
Author: Martin KaFai Lau <kafai@...com>
Date:   Wed May 11 17:06:05 2022 -0700

    net: inet: Retire port only listening_hash