netdev - Re: [PATCH v2] wifi: iw_handler.h: Remove unused declaration dev_get_wireless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e19091f1-497a-b673-9010-2e0a48d5942e@huawei.com>
Date: Sat, 5 Aug 2023 16:24:04 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <johannes@...solutions.net>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <linux-wireless@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: iw_handler.h: Remove unused declaration
 dev_get_wireless_info()

On 2023/8/5 15:53, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 09:36:17PM +0800, Yue Haibing wrote:
>> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211")
>> declared but never implemented this, remove it.
>>
>> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>> ---
>> v2: fix comment
>> ---
>>  include/net/iw_handler.h | 11 ++---------
>>  1 file changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h
>> index d2ea5863eedc..b2cf243ebe44 100644
>> --- a/include/net/iw_handler.h
>> +++ b/include/net/iw_handler.h
>> @@ -426,17 +426,10 @@ struct iw_public_data {
>>  
>>  /**************************** PROTOTYPES ****************************/
>>  /*
>> - * Functions part of the Wireless Extensions (defined in net/core/wireless.c).
>> - * Those may be called only within the kernel.
>> + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c).
> 
> Can I confirm that the wireless.c -> wext-core.c change is intentional?
> It doesn't seem strictly related to the patch description.

Commit 11433ee450eb ("[WEXT]: Move to net/wireless") rename  net/core/wireless.c to net/wireless/wext.c
then commit 3d23e349d807 ("wext: refactor") refactor wext.c to wext-core.c
The wext functions now sits in net/wireless/wext-core.c
This may need describe in patch description.
> 
>> + * Those may be called by driver modules.
>>   */
>>  
>> -/* First : function strictly used inside the kernel */
>> -
>> -/* Handle /proc/net/wireless, called in net/code/dev.c */
>> -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length);
>> -
>> -/* Second : functions that may be called by driver modules */
>> -
>>  /* Send a single event to user space */
>>  void wireless_send_event(struct net_device *dev, unsigned int cmd,
>>  			 union iwreq_data *wrqu, const char *extra);
>> -- 
>> 2.34.1
>>
> .
>