netdev - Re: [PATCH -next] mptcp: fix the incorrect judgment for msk->cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 04 Aug 2023 22:40:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Xiang Yang <xiangyang3@...wei.com>
Cc: matthieu.baerts@...sares.net, martineau@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, mptcp@...ts.linux.dev
Subject: Re: [PATCH -next] mptcp: fix the incorrect judgment for msk->cb_flags

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 3 Aug 2023 07:24:38 +0000 you wrote:
> Coccicheck reports the error below:
> net/mptcp/protocol.c:3330:15-28: ERROR: test of a variable/field address
> 
> Since the address of msk->cb_flags is used in __test_and_clear_bit, the
> address should not be NULL. The judgment for if (unlikely(msk->cb_flags))
> will always be true, we should check the real value of msk->cb_flags here.
> 
> [...]

Here is the summary with links:
  - [-next] mptcp: fix the incorrect judgment for msk->cb_flags
    https://git.kernel.org/netdev/net/c/17ebf8a4c38b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html