netdev - Re: [PATCH] net: hns: Remove a redundant check in hns_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <021855b4-972c-4df0-71c3-f1f415f9a881@huaweicloud.com>
Date: Sun, 6 Aug 2023 18:08:40 +0800
From: "Leizhen (ThunderTown)" <thunder.leizhen@...weicloud.com>
To: Simon Horman <horms@...nel.org>
Cc: Yisen Zhuang <yisen.zhuang@...wei.com>,
 Salil Mehta <salil.mehta@...wei.com>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, Zhen Lei <thunder.leizhen@...wei.com>
Subject: Re: [PATCH] net: hns: Remove a redundant check in hns_mdio_probe()

On 2023/8/5 19:29, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 05:27:53PM +0800, thunder.leizhen@...weicloud.com wrote:
>> From: Zhen Lei <thunder.leizhen@...wei.com>
>>
>> Traverse all devices when a new driver is installed, or, traverse all
>> drivers when a new device is added. In any case, the input argument
>> 'pdev' of drv->probe() cannot be NULL.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> 
> Please specify the target tree, net-next or net, for patches for this
> driver. In this case, as it isn't a bug fix, it would be net-next.
> 
> 	Subject: [PATCH net-next] ...

Sorry, this is my first patch for the net module. Do it next time.

> 
> That aside, this looks good to me.

Thanks.

> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> .
> 

-- 
Regards,
  Zhen Lei