netdev - Re: [PATCH net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 06 Aug 2023 12:30:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] net: omit ndo_hwtstamp_get() call when possible in
 dev_set_hwtstamp_phylib()

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@...emloft.net>:

On Fri,  4 Aug 2023 16:49:39 +0300 you wrote:
> Setting dev->priv_flags & IFF_SEE_ALL_HWTSTAMP_REQUESTS is only legal
> for drivers which were converted to ndo_hwtstamp_get() and
> ndo_hwtstamp_set(), and it is only there that we call ndo_hwtstamp_set()
> for a request that otherwise goes to phylib (for stuff like packet traps,
> which need to be undone if phylib failed, hence the old_cfg logic).
> 
> The problem is that we end up calling ndo_hwtstamp_get() when we don't
> need to (even if the SIOCSHWTSTAMP wasn't intended for phylib, or if it
> was, but the driver didn't set IFF_SEE_ALL_HWTSTAMP_REQUESTS). For those
> unnecessary conditions, we share a code path with virtual drivers (vlan,
> macvlan, bonding) where ndo_hwtstamp_get() is implemented as
> generic_hwtstamp_get_lower(), and may be resolved through
> generic_hwtstamp_ioctl_lower() if the lower device is unconverted.
> 
> [...]

Here is the summary with links:
  - [net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()
    https://git.kernel.org/netdev/net-next/c/c35e927cbe09

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html