netdev - Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa2a2ab1-1058-df2a-9fbb-19dd4f5edcd4@nvidia.com>
Date: Sun, 6 Aug 2023 16:47:56 +0300
From: Gal Pressman <gal@...dia.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: kuba@...nel.org, Daniel Borkmann <daniel@...earbox.net>, ast@...nel.org,
 bpf@...r.kernel.org, netdev@...r.kernel.org,
 syzbot+bdcf141f362ef83335cf@...kaller.appspotmail.com,
 syzbot+b202b7208664142954fa@...kaller.appspotmail.com,
 syzbot+14736e249bce46091c18@...kaller.appspotmail.com
Subject: Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon
 tcx_entry_free

On 04/08/2023 2:48, Martin KaFai Lau wrote:
> On 8/3/23 4:10 AM, Gal Pressman wrote:
>> On 22/07/2023 2:33, Daniel Borkmann wrote:
>>> On qdisc destruction, the ingress_destroy() needs to update the correct
>>> entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
>>> Therefore, fix the typo.
>>>
>>> Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with
>>> link support")
>>> Reported-by: syzbot+bdcf141f362ef83335cf@...kaller.appspotmail.com
>>> Reported-by: syzbot+b202b7208664142954fa@...kaller.appspotmail.com
>>> Reported-by: syzbot+14736e249bce46091c18@...kaller.appspotmail.com
>>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>>
>> Hi Daniel,
>>
>> Our nightly regression testing picked up new memory leaks which were
>> bisected to this commit.
> 
> Thanks for the report. Can you help to check if it can be reproduced
> with the latest net-next which has a tcx fix in commit 079082c60aff
> ("tcx: Fix splat during dev unregister")?
> 

I think the issue is resolved after this patch, but we're still verifying.
Thanks!