netdev - RE: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd3e9bb40d12421caaddda7279aece7a@realtek.com>
Date: Mon, 7 Aug 2023 01:41:33 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Ruan Jinjie <ruanjinjie@...wei.com>,
        "sgoutham@...vell.com"
	<sgoutham@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "s.shtylyov@....ru"
	<s.shtylyov@....ru>,
        "aspriel@...il.com" <aspriel@...il.com>,
        "franky.lin@...adcom.com" <franky.lin@...adcom.com>,
        "hante.meuleman@...adcom.com" <hante.meuleman@...adcom.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "richardcochran@...il.com"
	<richardcochran@...il.com>,
        "yoshihiro.shimoda.uh@...esas.com"
	<yoshihiro.shimoda.uh@...esas.com>,
        "u.kleine-koenig@...gutronix.de"
	<u.kleine-koenig@...gutronix.de>,
        "mkl@...gutronix.de" <mkl@...gutronix.de>,
        "lee@...nel.org" <lee@...nel.org>,
        "set_pte_at@...look.com"
	<set_pte_at@...look.com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>,
        "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "brcm80211-dev-list.pdl@...adcom.com"
	<brcm80211-dev-list.pdl@...adcom.com>,
        "SHA-cyfmac-dev-list@...ineon.com"
	<SHA-cyfmac-dev-list@...ineon.com>
Subject: RE: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator



> -----Original Message-----
> From: Ruan Jinjie <ruanjinjie@...wei.com>
> Sent: Friday, August 4, 2023 11:54 AM
> To: sgoutham@...vell.com; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> jesse.brandeburg@...el.com; anthony.l.nguyen@...el.com; tariqt@...dia.com; s.shtylyov@....ru;
> aspriel@...il.com; franky.lin@...adcom.com; hante.meuleman@...adcom.com; kvalo@...nel.org;
> richardcochran@...il.com; yoshihiro.shimoda.uh@...esas.com; ruanjinjie@...wei.com;
> u.kleine-koenig@...gutronix.de; mkl@...gutronix.de; lee@...nel.org; set_pte_at@...look.com;
> linux-arm-kernel@...ts.infradead.org; netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
> linux-rdma@...r.kernel.org; linux-renesas-soc@...r.kernel.org; linux-wireless@...r.kernel.org;
> brcm80211-dev-list.pdl@...adcom.com; SHA-cyfmac-dev-list@...ineon.com
> Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator
> 
> There is a ternary operator, the true or false judgement
> of which is unnecessary in C language semantics.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
> index 256a06b3c096..1c289488d050 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
> @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev)
>         mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH)
>                 ++num_eth_ports;
> 
> -       return (num_eth_ports ==  2) ? true : false;
> +       return num_eth_ports ==  2;

It should be one space between '=' and '2'.

>  }
> 
>  int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
> --
> 2.34.1
> 
> 
> ------Please consider the environment before printing this e-mail.