netdev - Re: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEXW_YQHGBE2kKupLf12BGOEU5GnQsBUtVQcyMnzxUZ4y48QFA@mail.gmail.com>
Date: Mon, 7 Aug 2023 10:14:48 -0400
From: Joel Fernandes <joel@...lfernandes.org>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: akpm@...ux-foundation.org, david@...morbit.com, tkhai@...ru, 
	vbabka@...e.cz, roman.gushchin@...ux.dev, djwong@...nel.org, 
	brauner@...nel.org, paulmck@...nel.org, tytso@....edu, steven.price@....com, 
	cel@...nel.org, senozhatsky@...omium.org, yujie.liu@...el.com, 
	gregkh@...uxfoundation.org, muchun.song@...ux.dev, simon.horman@...igine.com, 
	dlemoal@...nel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	x86@...nel.org, kvm@...r.kernel.org, xen-devel@...ts.xenproject.org, 
	linux-erofs@...ts.ozlabs.org, linux-f2fs-devel@...ts.sourceforge.net, 
	cluster-devel@...hat.com, linux-nfs@...r.kernel.org, 
	linux-mtd@...ts.infradead.org, rcu@...r.kernel.org, netdev@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org, 
	dm-devel@...hat.com, linux-raid@...r.kernel.org, linux-bcache@...r.kernel.org, 
	virtualization@...ts.linux-foundation.org, linux-fsdevel@...r.kernel.org, 
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, 
	linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker

On Mon, Aug 7, 2023 at 7:17 AM Qi Zheng <zhengqi.arch@...edance.com> wrote:
>
> Use new APIs to dynamically allocate the rcu-kfree shrinker.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

For RCU:
Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

thanks,

- Joel


> ---
>  kernel/rcu/tree.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 7c79480bfaa0..3b20fc46c514 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3449,13 +3449,6 @@ kfree_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
>         return freed == 0 ? SHRINK_STOP : freed;
>  }
>
> -static struct shrinker kfree_rcu_shrinker = {
> -       .count_objects = kfree_rcu_shrink_count,
> -       .scan_objects = kfree_rcu_shrink_scan,
> -       .batch = 0,
> -       .seeks = DEFAULT_SEEKS,
> -};
> -
>  void __init kfree_rcu_scheduler_running(void)
>  {
>         int cpu;
> @@ -4931,6 +4924,7 @@ static void __init kfree_rcu_batch_init(void)
>  {
>         int cpu;
>         int i, j;
> +       struct shrinker *kfree_rcu_shrinker;
>
>         /* Clamp it to [0:100] seconds interval. */
>         if (rcu_delay_page_cache_fill_msec < 0 ||
> @@ -4962,8 +4956,18 @@ static void __init kfree_rcu_batch_init(void)
>                 INIT_DELAYED_WORK(&krcp->page_cache_work, fill_page_cache_func);
>                 krcp->initialized = true;
>         }
> -       if (register_shrinker(&kfree_rcu_shrinker, "rcu-kfree"))
> -               pr_err("Failed to register kfree_rcu() shrinker!\n");
> +
> +       kfree_rcu_shrinker = shrinker_alloc(0, "rcu-kfree");
> +       if (!kfree_rcu_shrinker) {
> +               pr_err("Failed to allocate kfree_rcu() shrinker!\n");
> +               return;
> +       }
> +
> +       kfree_rcu_shrinker->count_objects = kfree_rcu_shrink_count;
> +       kfree_rcu_shrinker->scan_objects = kfree_rcu_shrink_scan;
> +       kfree_rcu_shrinker->seeks = DEFAULT_SEEKS;
> +
> +       shrinker_register(kfree_rcu_shrinker);
>  }
>
>  void __init rcu_init(void)
> --
> 2.30.2
>