netdev - Re: [PATCH net-next] net: bcmasp: Prevent array undereflow in bcmasp_netfilt_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <328f276c-bc89-6e41-b530-d916ee208d4d@broadcom.com>
Date: Mon, 7 Aug 2023 08:15:17 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Justin Chen <justin.chen@...adcom.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, bcm-kernel-feedback-list@...adcom.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: bcmasp: Prevent array undereflow in
 bcmasp_netfilt_get_init()

On 8/7/2023 6:01 AM, Dan Carpenter wrote:
> The "loc" value comes from the user and it can be negative leading to an
> an array underflow when we check "priv->net_filters[loc].claimed".  Fix
> this by changing the type to u32.
> 
> Fixes: c5d511c49587 ("net: bcmasp: Add support for wake on net filters")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)