lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <296d8c57-67aa-cb0a-8bab-538c52fb41e4@ti.com> Date: Mon, 7 Aug 2023 10:08:57 +0530 From: Md Danish Anwar <a0501179@...com> To: Conor Dooley <conor@...nel.org> CC: MD Danish Anwar <danishanwar@...com>, Randy Dunlap <rdunlap@...radead.org>, Roger Quadros <rogerq@...nel.org>, Simon Horman <simon.horman@...igine.com>, Vignesh Raghavendra <vigneshr@...com>, Andrew Lunn <andrew@...n.ch>, Richard Cochran <richardcochran@...il.com>, Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, <nm@...com>, <srk@...com>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [EXTERNAL] Re: [PATCH 1/4] dt-bindings: net: Add ICSS IEP On 04/08/23 9:05 pm, Conor Dooley wrote: > On Fri, Aug 04, 2023 at 11:56:19AM +0530, Md Danish Anwar wrote: >> Hi Conor, >> >> On 03/08/23 8:57 pm, Conor Dooley wrote: >>> On Thu, Aug 03, 2023 at 04:31:50PM +0530, MD Danish Anwar wrote: >>>> From: Md Danish Anwar <danishanwar@...com> >>>> >>>> Add DT binding documentation for ICSS IEP module. >>>> >>>> Signed-off-by: Md Danish Anwar <danishanwar@...com> >>>> --- >>>> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> new file mode 100644 >>>> index 000000000000..79cd72b330a6 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >>>> + >>>> +maintainers: >>>> + - Md Danish Anwar <danishanwar@...com> >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,am654-icss-iep # for K3 AM65x, J721E and AM64x SoCs >>> >>> No. ti,am654-icss-iep is for am654. You should really have compatibles >>> specific to the SoC - is there a reason why this has not been done? >>> >> >> Yes, ti,am654-icss-iep is for am654. You are right, the compatibles should be >> specific to SoC. Currently the upstream support is being added for only AM65x. >> >> I will remove J721E and AM64x SoCs from the comment above and these compatibles >> when their support is enabled in future. > > So the comment was totally wrong? Or does the same code work for all 3 > of these SoC types & you used the same compatible on each of the 3? Comment was not totally wrong, the same compatible currently works for all these 3 SoCs as the same code works for them. But for now as we are upstreaming only for AM65x, I will only keep am65x in the comment. > > Thanks, > Conor. > > >> Below is the updated compatible property. >> >> properties: >> compatible: >> enum: >> - ti,am654-icss-iep # for K3 AM65x SoCs -- Thanks and Regards, Danish.
Powered by blists - more mailing lists