netdev - Re: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <815f4639-7a21-4438-b9dc-0b36f9b08b17@huawei.com>
Date: Mon, 7 Aug 2023 12:59:38 +0800
From: Ruan Jinjie <ruanjinjie@...wei.com>
To: Ping-Ke Shih <pkshih@...ltek.com>, "sgoutham@...vell.com"
	<sgoutham@...vell.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
	"anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
	"tariqt@...dia.com" <tariqt@...dia.com>, "s.shtylyov@....ru"
	<s.shtylyov@....ru>, "aspriel@...il.com" <aspriel@...il.com>,
	"franky.lin@...adcom.com" <franky.lin@...adcom.com>,
	"hante.meuleman@...adcom.com" <hante.meuleman@...adcom.com>,
	"kvalo@...nel.org" <kvalo@...nel.org>, "richardcochran@...il.com"
	<richardcochran@...il.com>, "yoshihiro.shimoda.uh@...esas.com"
	<yoshihiro.shimoda.uh@...esas.com>, "u.kleine-koenig@...gutronix.de"
	<u.kleine-koenig@...gutronix.de>, "mkl@...gutronix.de" <mkl@...gutronix.de>,
	"lee@...nel.org" <lee@...nel.org>, "set_pte_at@...look.com"
	<set_pte_at@...look.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>, "brcm80211-dev-list.pdl@...adcom.com"
	<brcm80211-dev-list.pdl@...adcom.com>, "SHA-cyfmac-dev-list@...ineon.com"
	<SHA-cyfmac-dev-list@...ineon.com>
Subject: Re: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary
 operators



On 2023/8/7 9:39, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Ruan Jinjie <ruanjinjie@...wei.com>
>> Sent: Friday, August 4, 2023 11:54 AM
>> To: sgoutham@...vell.com; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
>> jesse.brandeburg@...el.com; anthony.l.nguyen@...el.com; tariqt@...dia.com; s.shtylyov@....ru;
>> aspriel@...il.com; franky.lin@...adcom.com; hante.meuleman@...adcom.com; kvalo@...nel.org;
>> richardcochran@...il.com; yoshihiro.shimoda.uh@...esas.com; ruanjinjie@...wei.com;
>> u.kleine-koenig@...gutronix.de; mkl@...gutronix.de; lee@...nel.org; set_pte_at@...look.com;
>> linux-arm-kernel@...ts.infradead.org; netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
>> linux-rdma@...r.kernel.org; linux-renesas-soc@...r.kernel.org; linux-wireless@...r.kernel.org;
>> brcm80211-dev-list.pdl@...adcom.com; SHA-cyfmac-dev-list@...ineon.com
>> Subject: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators
>>
>> Ther are a little ternary operators, the true or false judgement
>> of which is unnecessary in C language semantics.
>>
>> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
>> ---
>>  drivers/net/ethernet/cavium/thunder/nic_main.c    | 2 +-
>>  drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c
>> b/drivers/net/ethernet/cavium/thunder/nic_main.c
>> index 0ec65ec634df..b7cf4ba89b7c 100644
>> --- a/drivers/net/ethernet/cavium/thunder/nic_main.c
>> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
>> @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf)
>>                 if (mac)
>>                         ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac);
>>         }
>> -       mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false;
>> +       mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en;
>>         mbx.nic_cfg.node_id = nic->node;
>>
>>         mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en;
>> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> index a317feb8decb..9e467cecc33a 100644
>> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac)
>>                 goto next_poll;
>>         }
>>
>> -       lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false;
>> +       lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0;
> 
> lmac->link_up = !!(pcs_link & PCS_MRX_STATUS_LINK);

Thank you! I'll improve it sooner.

> 
>>         an_result = bgx_reg_read(lmac->bgx, lmac->lmacid,
>>                                  BGX_GMP_PCS_ANX_AN_RESULTS);
>>
>> --
>> 2.34.1
>>
>>
>> ------Please consider the environment before printing this e-mail.
>