lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <84f63b86-6d7d-9547-d4b7-d66a44b23c30@intel.com> Date: Mon, 7 Aug 2023 10:35:52 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: Ruan Jinjie <ruanjinjie@...wei.com>, <sgoutham@...vell.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>, <tariqt@...dia.com>, <s.shtylyov@....ru>, <aspriel@...il.com>, <franky.lin@...adcom.com>, <hante.meuleman@...adcom.com>, <kvalo@...nel.org>, <richardcochran@...il.com>, <yoshihiro.shimoda.uh@...esas.com>, <u.kleine-koenig@...gutronix.de>, <mkl@...gutronix.de>, <lee@...nel.org>, <set_pte_at@...look.com>, <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>, <linux-rdma@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>, <linux-wireless@...r.kernel.org>, <brcm80211-dev-list.pdl@...adcom.com>, <SHA-cyfmac-dev-list@...ineon.com> Subject: Re: [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators On 8/3/2023 8:53 PM, Ruan Jinjie wrote: > Ther are a little ternary operators, the true or false judgement > of which is unnecessary in C language semantics. > > Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com> > --- > drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +- > drivers/net/ethernet/intel/igc/igc_phy.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c > index a018000f7db9..c123c9dd6a49 100644 > --- a/drivers/net/ethernet/intel/igb/e1000_phy.c > +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c > @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations, > udelay(usec_interval); > } > > - *success = (i < iterations) ? true : false; > + *success = i < iterations; > > return ret_val; > } > diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c > index 53b77c969c85..a553e9d719e7 100644 > --- a/drivers/net/ethernet/intel/igc/igc_phy.c > +++ b/drivers/net/ethernet/intel/igc/igc_phy.c > @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations, > udelay(usec_interval); > } > > - *success = (i < iterations) ? true : false; > + *success = i < iterations; > > return ret_val; > } Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
Powered by blists - more mailing lists