netdev - Re: [PATCH iproute2 1/2] tc/taprio: don't print netlink attributes which weren't reported by the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230807220054.ghrawyp6xp4xk5bt@skbuf>
Date: Tue, 8 Aug 2023 01:00:54 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 1/2] tc/taprio: don't print netlink attributes
 which weren't reported by the kernel

On Mon, Aug 07, 2023 at 01:15:45PM -0700, Vinicius Costa Gomes wrote:
> nitpick, optional: as you are already opening blocks for each of the
> fields, you could move these declarations there. (same comment for the
> next patch)
> 
> For the series:
> 
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

Thanks for the review. I will submit a v2 with your comment addressed
(all variables defined within the smallest block in which they are used).
But as for "same comment for the next patch": the next patch is a single
line change which keeps the control flow the same.