netdev - Re: [PATCH v2 net-next 1/3] led: trig: netdev: Fix requesting offload device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d53dd9f4-b37f-4482-97e2-4e8a3fc6fea5@lunn.ch>
Date: Tue, 8 Aug 2023 00:27:10 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: netdev <netdev@...r.kernel.org>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <rmk+kernel@...linux.org.uk>,
	Simon Horman <simon.horman@...igine.com>,
	Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH v2 net-next 1/3] led: trig: netdev: Fix requesting
 offload device

> > +	if (supports_hw_control(led_cdev)) {
> >  		dev = led_cdev->hw_control_get_device(led_cdev);
> >  		if (dev) {
> >  			const char *name = dev_name(dev);
> >  
> >  			set_device_name(trigger_data, name, strlen(name));
> >  			trigger_data->hw_control = true;
> > -			trigger_data->mode = mode;
> > +
> > +			rc = led_cdev->hw_control_get(led_cdev, &mode);
> 
> Shouldn't there also be something like
> led_cdev->hw_control_get(led_cdev, 0);
> in netdev_trig_deactivate then?
> Because somehow we need to tell the hardware to no longer perform an
> offloading operation.

Hi Daniel

Back from vacation, so getting around to this now.

Interesting question. I would actually expect the trigger that takes
its place will set the brightness to what it wants it to default
it. It is documented that setting the brightness disables any offload.

Have you seen a real problem with changing triggers?

     Andrew