lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <BY3PR18MB4707D17FD94F2700F9E85226A00CA@BY3PR18MB4707.namprd18.prod.outlook.com> Date: Mon, 7 Aug 2023 06:41:22 +0000 From: Sai Krishna Gajula <saikrishnag@...vell.com> To: Simon Horman <horms@...nel.org> CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sunil Kovvuri Goutham <sgoutham@...vell.com>, Geethasowjanya Akula <gakula@...vell.com>, Subbaraya Sundeep Bhatta <sbhatta@...vell.com>, Hariprasad Kelam <hkelam@...vell.com>, "richardcochran@...il.com" <richardcochran@...il.com>, Naveen Mamindlapalli <naveenm@...vell.com> Subject: Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp counter atomic update feature > -----Original Message----- > From: Simon Horman <horms@...nel.org> > Sent: Saturday, August 5, 2023 5:04 PM > To: Sai Krishna Gajula <saikrishnag@...vell.com> > Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; > pabeni@...hat.com; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>; > Geethasowjanya Akula <gakula@...vell.com>; Subbaraya Sundeep Bhatta > <sbhatta@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>; > richardcochran@...il.com; Naveen Mamindlapalli > <naveenm@...vell.com> > Subject: Re: [net-next PATCH] octeontx2-pf: Use PTP HW timestamp > counter atomic update feature > > On Fri, Aug 04, 2023 at 03:00:14PM +0530, Sai Krishna wrote: > > Some of the newer silicon versions in CN10K series supports a feature > > where in the current PTP timestamp in HW can be updated atomically > > without losing any cpu cycles unlike read/modify/write register. > > This patch uses this feature so that PTP accuracy can be improved > > while adjusting the master offset in HW. There is no need for SW > > timecounter when using this feature. So removed references to SW > > timecounter wherever appropriate. > > > > Signed-off-by: Sai Krishna <saikrishnag@...vell.com> > > Signed-off-by: Naveen Mamindlapalli <naveenm@...vell.com> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com> > > ... > > > struct npc_get_field_status_req { > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c > > b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c > > ... > > > > > -static bool is_ptp_tsfmt_sec_nsec(struct ptp *ptp) > > +static inline bool is_tstmp_atomic_update_supported(struct rvu *rvu) > > Hi Sai, > > Please avoid using the inline keyword for functions in .c files. > Unless there is a demonstrable advantage to doing so it should be left up to > the compiler to inline or not. Ok, will remove inline keyword and submit V2 patch. Thanks, Sai > > ... > > -- > pw-bot: changes-requested
Powered by blists - more mailing lists