netdev - Re: [net-next v3 4/7] net: openvswitch: add meter drop reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 08 Aug 2023 10:53:51 -0400
From: Aaron Conole <aconole@...hat.com>
To: Adrian Moreno <amorenoz@...hat.com>
Cc: netdev@...r.kernel.org,  i.maximets@....org,  eric@...ver.life,
  dev@...nvswitch.org
Subject: Re: [net-next v3 4/7] net: openvswitch: add meter drop reason

Adrian Moreno <amorenoz@...hat.com> writes:

> By using an independent drop reason it makes it easy to ditinguish

nit: distinguish

> between QoS-triggered or flow-triggered drop.
>
> Signed-off-by: Adrian Moreno <amorenoz@...hat.com>
> ---

Acked-by: Aaron Conole <aconole@...hat.com>

>  net/openvswitch/actions.c | 2 +-
>  net/openvswitch/drop.h    | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index 285b1243b94f..e204c7eee8ef 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -1454,7 +1454,7 @@ static int do_execute_actions(struct datapath *dp, struct sk_buff *skb,
>  
>  		case OVS_ACTION_ATTR_METER:
>  			if (ovs_meter_execute(dp, skb, key, nla_get_u32(a))) {
> -				consume_skb(skb);
> +				kfree_skb_reason(skb, OVS_DROP_METER);
>  				return 0;
>  			}
>  			break;
> diff --git a/net/openvswitch/drop.h b/net/openvswitch/drop.h
> index be51ff5039fb..1ba866c408e5 100644
> --- a/net/openvswitch/drop.h
> +++ b/net/openvswitch/drop.h
> @@ -12,6 +12,7 @@
>  	R(OVS_DROP_ACTION_ERROR)		\
>  	R(OVS_DROP_EXPLICIT_ACTION)		\
>  	R(OVS_DROP_EXPLICIT_ACTION_ERROR)	\
> +	R(OVS_DROP_METER)			\
>  	/* deliberate comment for trailing \ */
>  
>  enum ovs_drop_reason {