netdev - Re: [PATCH -next] net: pcs: Add missing put_device call in miic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d309cd3-7c73-65fd-7e0b-d0491f1c2d67@huaweicloud.com>
Date: Tue, 8 Aug 2023 19:56:53 +0800
From: Xiang Yang <xiangyang@...weicloud.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: clement.leger@...tlin.com, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, f.fainelli@...il.com, linux-renesas-soc@...r.kernel.org,
 netdev@...r.kernel.org, xiangyang3@...wei.com
Subject: Re: [PATCH -next] net: pcs: Add missing put_device call in
 miic_create



在 2023/8/8 18:54, Vladimir Oltean 写道:
> On Mon, Aug 07, 2023 at 01:47:14PM +0000, Xiang Yang wrote:
>> From: Xiang Yang <xiangyang3@...wei.com>
>>
>> The reference of pdev->dev is taken by of_find_device_by_node, so
>> it should be released when error out.
>>
>> Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
>> Signed-off-by: Xiang Yang <xiangyang3@...wei.com>
>> ---
> 
> Also, the patch subject prefix needs to be "[PATCH net]" (indicative of
> the fact that you want it to go to https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git)
> and not "[PATCH -next]".
Thanks, I will change the patch subject prefix and resend the patch of
v2 with your advice.