netdev - [PATCH net 0/3] nexthop: Nexthop dump fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 10:52:30 +0300
From: Ido Schimmel <idosch@...dia.com>
To: <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<edumazet@...gle.com>, <dsahern@...nel.org>, <petrm@...dia.com>, Ido Schimmel
	<idosch@...dia.com>
Subject: [PATCH net 0/3] nexthop: Nexthop dump fixes

Patches #1 and #3 fix two problems related to nexthops and nexthop
buckets dump, respectively. Patch #2 is a preparation for the third
patch.

The pattern described in these patches of splitting the NLMSG_DONE to a
separate response is prevalent in other rtnetlink dump callbacks. I
don't know if it's because I'm missing something or if this was done
intentionally to ensure the message is delivered to user space. After
commit 0642840b8bb0 ("af_netlink: ensure that NLMSG_DONE never fails in
dumps") this is no longer necessary and I can improve these dump
callbacks assuming this analysis is correct.

No regressions in existing tests:

 # ./fib_nexthops.sh
 [...]
 Tests passed: 230
 Tests failed:   0

Ido Schimmel (3):
  nexthop: Fix infinite nexthop dump when using maximum nexthop ID
  nexthop: Make nexthop bucket dump more efficient
  nexthop: Fix infinite nexthop bucket dump when using maximum nexthop
    ID

 net/ipv4/nexthop.c                          | 28 ++++++---------------
 tools/testing/selftests/net/fib_nexthops.sh | 10 ++++++++
 2 files changed, 17 insertions(+), 21 deletions(-)

-- 
2.40.1