netdev - Re: [PATCH linux-next v2] net/ipv4: return the real errno instead of -EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 14:11:19 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: xu.xin.sc@...il.com
Cc: dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 xu xin <xu.xin16@....com.cn>, Yang Yang <yang.yang29@....com.cn>,
 Si Hao <si.hao@....com.cn>, davem@...emloft.net
Subject: Re: [PATCH linux-next v2] net/ipv4: return the real errno instead of
 -EINVAL

On 07/08/2023 02:54, xu.xin.sc@...il.com wrote:
> From: xu xin <xu.xin16@....com.cn>
> 
> For now, No matter what error pointer ip_neigh_for_gw() returns,
> ip_finish_output2() always return -EINVAL, which may mislead the upper
> users.
> 
> For exemple, an application uses sendto to send an UDP packet, but when the
> neighbor table overflows, sendto() will get a value of -EINVAL, and it will
> cause users to waste a lot of time checking parameters for errors.
> 
> Return the real errno instead of -EINVAL.
> 
> Signed-off-by: xu xin <xu.xin16@....com.cn>
> Reviewed-by: Yang Yang <yang.yang29@....com.cn>
> Cc: Si Hao <si.hao@....com.cn>
> ---

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>