netdev - Re: [PATCH net-next] net: dsa: mt7530: improve and relax PHY driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 12:35:29 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Daniel Golle <daniel@...rotopia.org>,
	Russell King <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>
Cc: Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: improve and relax PHY driver
 dependency

On Sat, Aug 05, 2023 at 03:45:36PM +0100, Daniel Golle wrote:
> Different MT7530 variants require different PHY drivers.
> Use 'imply' instead of 'select' to relax the dependency on the PHY
> driver, and choose the appropriate driver.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  drivers/net/dsa/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
> index 3ed5391bb18d6..f8c1d73b251d0 100644
> --- a/drivers/net/dsa/Kconfig
> +++ b/drivers/net/dsa/Kconfig
> @@ -37,7 +37,6 @@ config NET_DSA_LANTIQ_GSWIP
>  config NET_DSA_MT7530
>  	tristate "MediaTek MT7530 and MT7531 Ethernet switch support"
>  	select NET_DSA_TAG_MTK
> -	select MEDIATEK_GE_PHY
>  	imply NET_DSA_MT7530_MDIO
>  	imply NET_DSA_MT7530_MMIO
>  	help
> @@ -49,6 +48,7 @@ config NET_DSA_MT7530
>  config NET_DSA_MT7530_MDIO
>  	tristate "MediaTek MT7530 MDIO interface driver"
>  	depends on NET_DSA_MT7530
> +	imply MEDIATEK_GE_PHY
>  	select PCS_MTK_LYNXI
>  	help
>  	  This enables support for the MediaTek MT7530 and MT7531 switch
> @@ -60,6 +60,7 @@ config NET_DSA_MT7530_MMIO
>  	tristate "MediaTek MT7530 MMIO interface driver"
>  	depends on NET_DSA_MT7530
>  	depends on HAS_IOMEM
> +	imply MEDIATEK_GE_SOC_PHY
>  	help
>  	  This enables support for the built-in Ethernet switch found
>  	  in the MediaTek MT7988 SoC.
> -- 
> 2.41.0

Reviewed-by: Vladimir Oltean <olteanv@...il.com>

But I did a tree-wide search for "imply .*_PHY" and I didn't find any
other usage patterns, so I'm adding all phylib maintainers to make sure
that the practice isn't discouraged. If not, I guess it should be used
more often with internal PHYs for which the driver is known.