netdev - Re: [PATCH net-next v5 1/2] drivers: net: prevent tun_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 08 Aug 2023 02:20:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Andrew Kanner <andrew.kanner@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, jasowang@...hat.com, netdev@...r.kernel.org,
 hawk@...nel.org, jbrouer@...hat.com, dsahern@...il.com,
 john.fastabend@...il.com, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org,
 syzbot+f817490f5bd20541b90a@...kaller.appspotmail.com
Subject: Re: [PATCH net-next v5 1/2] drivers: net: prevent tun_build_skb() to
 exceed the packet size limit

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu,  3 Aug 2023 20:59:48 +0200 you wrote:
> Using the syzkaller repro with reduced packet size it was discovered
> that XDP_PACKET_HEADROOM is not checked in tun_can_build_skb(),
> although pad may be incremented in tun_build_skb(). This may end up
> with exceeding the PAGE_SIZE limit in tun_build_skb().
> 
> Jason Wang <jasowang@...hat.com> proposed to count XDP_PACKET_HEADROOM
> always (e.g. without rcu_access_pointer(tun->xdp_prog)) in
> tun_can_build_skb() since there's a window during which XDP program
> might be attached between tun_can_build_skb() and tun_build_skb().
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/2] drivers: net: prevent tun_build_skb() to exceed the packet size limit
    https://git.kernel.org/netdev/net/c/59eeb2329405
  - [net-next,v5,2/2] net: core: remove unnecessary frame_sz check in bpf_xdp_adjust_tail()
    https://git.kernel.org/netdev/net/c/d14eea09edf4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html