netdev - Re: [PATCH net-next 2/2] bnxt_en: Fix W=stringop-overflow warning in bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 05:18:10 -0600
From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com,
	gustavo@...eddedor.com
Subject: Re: [PATCH net-next 2/2] bnxt_en: Fix W=stringop-overflow warning in
 bnxt_dcb.c

On Mon, Aug 07, 2023 at 07:57:20AM -0700, Michael Chan wrote:
> Fix the following warning:
> 
> drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c: In function ‘bnxt_hwrm_queue_cos2bw_cfg’:
> cc1: error: writing 12 bytes into a region of size 1 [-Werror=stringop-overflow ]
> In file included from drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:19:
> drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h:6045:17: note: destination object ‘unused_0’ of size 1
>  6045 |         u8      unused_0;
> 
> Fix it by modifying struct hwrm_queue_cos2bw_cfg_input to use an array
> of sub struct similar to the previous patch.  This will eliminate the
> pointer arithmetc to calculate the destination pointer passed to
> memcpy().

Thanks for fixing this. :)

> 
> Link: https://lore.kernel.org/netdev/CACKFLinikvXmKcxr4kjWO9TPYxTd2cb5agT1j=w9Qyj5-24s5A@mail.gmail.com/
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

--
Gustavo