netdev - Re: [PATCH net 1/2] Revert "ice: Fix ice VF reset during iavf initialization"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 8 Aug 2023 14:51:41 +0200
From: Simon Horman <horms@...nel.org>
To: Petr Oros <poros@...hat.com>
Cc: netdev@...r.kernel.org, jesse.brandeburg@...el.com,
	anthony.l.nguyen@...el.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	Jacob.e.keller@...el.com, przemyslawx.patynowski@...el.com,
	kamil.maziarz@...el.com, dawidx.wesierski@...el.com,
	mateusz.palczewski@...el.com, slawomirx.laba@...el.com,
	norbertx.zulinski@...el.com, intel-wired-lan@...ts.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] Revert "ice: Fix ice VF reset during iavf
 initialization"

On Mon, Aug 07, 2023 at 11:48:30AM +0200, Petr Oros wrote:
> This reverts commit 7255355a0636b4eff08d5e8139c77d98f151c4fc.
> 
> After this commit we are not able to attach VF to VM:
> virsh attach-interface v0 hostdev --managed 0000:41:01.0 --mac 52:52:52:52:52:52
> error: Failed to attach interface
> error: Cannot set interface MAC to 52:52:52:52:52:52 for ifname enp65s0f0np0 vf 0: Resource temporarily unavailable
> 
> ice_check_vf_ready_for_cfg() already contain waiting for reset.
> New condition in ice_check_vf_ready_for_reset() causing only problems.
> 
> Fixes: 7255355a0636 ("ice: Fix ice VF reset during iavf initialization")
> Signed-off-by: Petr Oros <poros@...hat.com>

Reviewed-by: Simon Horman <horms@...nel.org>