netdev - Re: [PATCH v2 2/8] io_uring/cmd: Introduce SOCKET_URING_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 9 Aug 2023 18:27:48 +0800
From: kernel test robot <lkp@...el.com>
To: Breno Leitao <leitao@...ian.org>, sdf@...gle.com, axboe@...nel.dk,
	asml.silence@...il.com, willemdebruijn.kernel@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	io-uring@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH v2 2/8] io_uring/cmd: Introduce SOCKET_URING_OP_GETSOCKOPT

Hi Breno,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20230808]
[cannot apply to bpf-next/master bpf/master net/main net-next/main linus/master horms-ipvs/master v6.5-rc5 v6.5-rc4 v6.5-rc3 v6.5-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Breno-Leitao/net-expose-sock_use_custom_sol_socket/20230809-011901
base:   next-20230808
patch link:    https://lore.kernel.org/r/20230808134049.1407498-3-leitao%40debian.org
patch subject: [PATCH v2 2/8] io_uring/cmd: Introduce SOCKET_URING_OP_GETSOCKOPT
config: m68k-randconfig-r036-20230809 (https://download.01.org/0day-ci/archive/20230809/202308091701.sGyLMOi2-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091701.sGyLMOi2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308091701.sGyLMOi2-lkp@intel.com/

All errors (new ones prefixed by >>):

   m68k-linux-ld: io_uring/uring_cmd.o: in function `io_uring_cmd_sock':
>> io_uring/uring_cmd.c:183: undefined reference to `sk_getsockopt'


vim +183 io_uring/uring_cmd.c

   168	
   169	static inline int io_uring_cmd_getsockopt(struct socket *sock,
   170						  struct io_uring_cmd *cmd)
   171	{
   172		void __user *optval = u64_to_user_ptr(READ_ONCE(cmd->sqe->optval));
   173		int optname = READ_ONCE(cmd->sqe->optname);
   174		int optlen = READ_ONCE(cmd->sqe->optlen);
   175		int level = READ_ONCE(cmd->sqe->level);
   176		int err;
   177	
   178		err = security_socket_getsockopt(sock, level, optname);
   179		if (err)
   180			return err;
   181	
   182		if (level == SOL_SOCKET) {
 > 183			err = sk_getsockopt(sock->sk, level, optname,
   184					    USER_SOCKPTR(optval),
   185					    KERNEL_SOCKPTR(&optlen));
   186			if (err)
   187				return err;
   188	
   189			return optlen;
   190		}
   191	
   192		return -EOPNOTSUPP;
   193	}
   194	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki