netdev - Re: [PATCH] net: txgbe: Use pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 9 Aug 2023 14:38:20 +0200
From: Simon Horman <horms@...nel.org>
To: Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc: jiawenwu@...stnetic.com, mengyuanlou@...-swift.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	maciej.fijalkowski@...el.com, andrew@...n.ch,
	piotr.raczynski@...el.com, netdev@...r.kernel.org,
	yangyingliang@...wei.com
Subject: Re: [PATCH] net: txgbe: Use pci_dev_id() to simplify the code

On Tue, Aug 08, 2023 at 10:49:31AM +0800, Xiongfeng Wang wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to

nit: mannually -> manually

checkpatch.pl --codespell is your friend here.


> simplify the code a little bit.
> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>

Otherwise this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>