netdev - Re: [PATCH net] devlink: Delay health recover notification until devlink registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230808161834.71d5391d@kernel.org>
Date: Tue, 8 Aug 2023 16:18:34 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shay Drory <shayd@...dia.com>
Cc: <netdev@...r.kernel.org>, <pabeni@...hat.com>, <davem@...emloft.net>,
 <edumazet@...gle.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net] devlink: Delay health recover notification until
 devlink registered

On Tue, 8 Aug 2023 16:37:20 +0300 Shay Drory wrote:
> Currently, invoking health recover before devlink_register() triggers
> a WARN_ON. However, it is possible for a device to have health errors
> during its probing flow, before the device driver will call to
> devlink_register(). e.g.: it is valid to invoke health recover before
> devlink_register().
> 
> Hence, apply delay notification mechanism to health reporters.

devlink_register() is dead, long live devl_register().

At the very least the commit message should enlighten us as to why 
the devlink instance can't be registered first, before the health
reporter.