| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Aug 2023 22:19:09 +0800
From: kernel test robot <lkp@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6060: add phylink_get_caps
implementation
Hi Russell,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-dsa-mv88e6060-add-phylink_get_caps-implementation/20230809-203318
base: net-next/main
patch link: https://lore.kernel.org/r/E1qTiMC-003FJP-V3%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next] net: dsa: mv88e6060: add phylink_get_caps implementation
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230809/202308092253.LelgPpOb-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230809/202308092253.LelgPpOb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308092253.LelgPpOb-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/dma-mapping.h:8,
from include/linux/skbuff.h:28,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/dsa/mv88e6060.c:8:
drivers/net/dsa/mv88e6060.c: In function 'mv88e6060_phylink_get_caps':
>> drivers/net/dsa/mv88e6060.c:262:39: warning: passing argument 1 of 'PTR_ERR' makes pointer from integer without a cast [-Wint-conversion]
262 | port, PTR_ERR(ret));
| ^~~
| |
| int
include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/net/dsa/mv88e6060.c:260:17: note: in expansion of macro 'dev_err'
260 | dev_err(ds->dev,
| ^~~~~~~
In file included from include/linux/rwsem.h:17,
from include/linux/mm_types.h:13,
from include/linux/mmzone.h:22,
from include/linux/gfp.h:7,
from include/linux/xarray.h:15,
from include/linux/list_lru.h:14,
from include/linux/fs.h:13,
from include/linux/highmem.h:5,
from include/linux/bvec.h:10,
from include/linux/skbuff.h:17:
include/linux/err.h:49:61: note: expected 'const void *' but argument is of type 'int'
49 | static inline long __must_check PTR_ERR(__force const void *ptr)
| ~~~~~~~~~~~~^~~
>> drivers/net/dsa/mv88e6060.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'long int' [-Wformat=]
261 | "port %d: unable to read status register: %pe\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/net/dsa/mv88e6060.c:260:17: note: in expansion of macro 'dev_err'
260 | dev_err(ds->dev,
| ^~~~~~~
drivers/net/dsa/mv88e6060.c:261:68: note: format string is defined here
261 | "port %d: unable to read status register: %pe\n",
| ~^
| |
| void *
| %ld
vim +/PTR_ERR +262 drivers/net/dsa/mv88e6060.c
249
250 static void mv88e6060_phylink_get_caps(struct dsa_switch *ds, int port,
251 struct phylink_config *config)
252 {
253 unsigned long *interfaces = config->supported_interfaces;
254 struct mv88e6060_priv *priv = ds->priv;
255 int addr = REG_PORT(port);
256 int ret;
257
258 ret = reg_read(priv, addr, PORT_STATUS);
259 if (ret < 0) {
260 dev_err(ds->dev,
> 261 "port %d: unable to read status register: %pe\n",
> 262 port, PTR_ERR(ret));
263 return;
264 }
265
266 if (!(ret & PORT_STATUS_PORTMODE)) {
267 /* Port configured in SNI mode (acts as a 10Mbps PHY) */
268 config->mac_capabilities = MAC_10 | MAC_SYM_PAUSE;
269 /* I don't think SNI is SMII - SMII has a sync signal, and
270 * SNI doesn't.
271 */
272 __set_bit(PHY_INTERFACE_MODE_SMII, interfaces);
273 return;
274 }
275
276 config->mac_capabilities = MAC_100 | MAC_10 | MAC_SYM_PAUSE;
277
278 if (port >= 4) {
279 /* Ports 4 and 5 can support MII, REVMII and REVRMII modes */
280 __set_bit(PHY_INTERFACE_MODE_MII, interfaces);
281 __set_bit(PHY_INTERFACE_MODE_REVMII, interfaces);
282 __set_bit(PHY_INTERFACE_MODE_REVRMII, interfaces);
283 }
284 if (port <= 4) {
285 /* Ports 0 to 3 have internal PHYs, and port 4 can optionally
286 * use an internal PHY.
287 */
288 /* Internal PHY */
289 __set_bit(PHY_INTERFACE_MODE_INTERNAL, interfaces);
290 /* Default phylib interface mode */
291 __set_bit(PHY_INTERFACE_MODE_GMII, interfaces);
292 }
293 }
294
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists