netdev - Re: [PATCH net-next 0/2] mlxsw: Set port STP state on bridge enslavement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNOnxIdDNEsZN+j/@vergenet.net>
Date: Wed, 9 Aug 2023 16:50:44 +0200
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Danielle Ratson <danieller@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 0/2] mlxsw: Set port STP state on bridge
 enslavement

On Tue, Aug 08, 2023 at 03:18:14PM +0200, Petr Machata wrote:
> When the first port joins a LAG that already has a bridge upper, an
> instance of struct mlxsw_sp_bridge_port is created for the LAG to keep
> track of it as a bridge port. The bridge_port's STP state is initialized to
> BR_STATE_DISABLED. This made sense previously, because mlxsw would only
> ever allow a port to join a LAG if the LAG had no uppers. Thus if a
> bridge_port was instantiated, it must have been because the LAG as such is
> joining a bridge, and the STP state is correspondingly disabled.
> 
> However as of commit 2c5ffe8d7226 ("mlxsw: spectrum: Permit enslavement to
> netdevices with uppers"), mlxsw allows a port to join a LAG that is already
> a member of a bridge. The STP state may be different than disabled in that
> case. Initialize it properly by querying the actual state.
> 
> This bug may cause an issue as traffic on ports attached to a bridged LAG
> gets dropped on ingress with discard_ingress_general counter bumped.
> 
> The above fix in patch #1. Patch #2 contains a selftest that would
> sporadically reproduce the issue.
> 
> Petr Machata (2):
>   mlxsw: Set port STP state on bridge enslavement
>   selftests: mlxsw: router_bridge_lag: Add a new selftest

Reviewed-by: Simon Horman <horms@...nel.org>