[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id:
<169161242247.16318.3088407520751400257.git-patchwork-notify@kernel.org>
Date: Wed, 09 Aug 2023 20:20:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
Cc: andrew@...n.ch, hkallweit1@...il.com, f.fainelli@...il.com,
olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mark parsed interface mode for legacy
switch drivers
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:
On Tue, 08 Aug 2023 12:12:16 +0100 you wrote:
> If we successfully parsed an interface mode with a legacy switch
> driver, populate that mode into phylink's supported interfaces rather
> than defaulting to the internal and gmii interfaces.
>
> This hasn't caused an issue so far, because when the interface doesn't
> match a supported one, phylink_validate() doesn't clear the supported
> mask, but instead returns -EINVAL. phylink_parse_fixedlink() doesn't
> check this return value, and merely relies on the supported ethtool
> link modes mask being cleared. Therefore, the fixed link settings end
> up being allowed despite validation failing.
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: mark parsed interface mode for legacy switch drivers
https://git.kernel.org/netdev/net-next/c/145622771d22
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists