netdev - Re: [PATCH net v2 09/17] selftests: forwarding: hw_stats_l3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNMoFwARQ70DPLT6@shredder>
Date: Wed, 9 Aug 2023 08:45:59 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, petrm@...dia.com, razor@...ckwall.org,
	mirsad.todorovac@....unizg.hr
Subject: Re: [PATCH net v2 09/17] selftests: forwarding: hw_stats_l3_gre:
 Skip when using veth pairs

On Wed, Aug 09, 2023 at 10:02:22AM +0800, Hangbin Liu wrote:
> On Tue, Aug 08, 2023 at 05:14:55PM +0300, Ido Schimmel wrote:
> > Layer 3 hardware stats cannot be used when the underlying interfaces are
> > veth pairs, resulting in failures:
> > 
> >  # ./hw_stats_l3_gre.sh
> >  TEST: ping gre flat                                                 [ OK ]
> >  TEST: Test rx packets:                                              [FAIL]
> >          Traffic not reflected in the counter: 0 -> 0
> >  TEST: Test tx packets:                                              [FAIL]
> >          Traffic not reflected in the counter: 0 -> 0
> > 
> > Fix by skipping the test when used with veth pairs.
> > 
> > Fixes: 813f97a26860 ("selftests: forwarding: Add a tunnel-based test for L3 HW stats")
> > Reported-by: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
> > Closes: https://lore.kernel.org/netdev/adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr/
> > Signed-off-by: Ido Schimmel <idosch@...dia.com>
> > Reviewed-by: Petr Machata <petrm@...dia.com>
> > Tested-by: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
> > ---
> >  tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh b/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > index eb9ec4a68f84..7594bbb49029 100755
> > --- a/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > +++ b/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > @@ -99,6 +99,8 @@ test_stats_rx()
> >  	test_stats g2a rx
> >  }
> >  
> > +skip_on_veth
> > +
> >  trap cleanup EXIT
> >  
> >  setup_prepare
> 
> Petr has been add a veth check for this script in a9fda7a0b033 ("selftests:
> forwarding: hw_stats_l3: Detect failure to install counters"). I think we can
> remove it with your patch?

Yes, I plan to remove it in net-next.