netdev - Re: [PATCH net-next 03/10] genetlink: remove userhdr from struct genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNSfLomTSZy/4b8W@nanopsycho>
Date: Thu, 10 Aug 2023 10:26:22 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, johannes@...solutions.net,
	philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
	christoph.boehmwalder@...bit.com, axboe@...nel.dk, pshelar@....org,
	jmaloy@...hat.com, ying.xue@...driver.com, jacob.e.keller@...el.com,
	drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org,
	dev@...nvswitch.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 03/10] genetlink: remove userhdr from struct
 genl_info

Wed, Aug 09, 2023 at 08:26:41PM CEST, kuba@...nel.org wrote:
>Only three families use info->userhdr and fixed headers
>are discouraged for new families. So remove the pointer
>from struct genl_info to save some space. Compute
>the header pointer at runtime. Saved space will be used
>for a family pointer in later patches.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>

I'm fine with the existing message, but what Johannes suggests is also
ok.