netdev - Re: [PATCH v1 mptcp-next] mptcp: Remove unnecessary test for __mptcp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05c9cfb7-c704-4b72-8fa3-d280dae80c09@tessares.net>
Date: Thu, 10 Aug 2023 11:51:39 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 Mat Martineau <martineau@...nel.org>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, mptcp@...ts.linux.dev,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1 mptcp-next] mptcp: Remove unnecessary test for
 __mptcp_init_sock().

Hi Kuniyuki,

On 10/08/2023 00:59, Kuniyuki Iwashima wrote:
> __mptcp_init_sock() always returns 0 because mptcp_init_sock() used
> to return the value directly.
> 
> But after commit 18b683bff89d ("mptcp: queue data for mptcp level
> retransmission"), __mptcp_init_sock() need not return value anymore.
> 
> Let's remove the unnecessary test for __mptcp_init_sock() and make
> it return void.

Thank you for your patch, it looks good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

As the CI said (on MPTCP ML only), there is a conflict with another
patch already in MPTCP tree that is going to be sent later. But that's
fine, no need to rebase, it is fine to apply your patch as it is in our
tree before the other patch and modify the latter one to avoid
compilation issue.

So just to be clear, I just applied this patch in MPTCP tree and we will
send it to Netdev later. I hope it is OK if I change the Patchwork
status to "Deferred". (If it is the correct status because it looks like
the "Handled Elsewhere" status is not used in Netdev PW and the bot
doesn't support it).

pw-bot: defer

New patches for t/upstream:
- 769fb24aa39c: mptcp: Remove unnecessary test for __mptcp_init_sock()
- 1ba457522bce: mptcp: fix compilation issue in "mptcp: add sched in
mptcp_sock"
- Results: 3a7cf9f5d51c..649448c9126d (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230810T092803

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net