netdev - Re: [PATCH] net: sfp: handle 100G/25G active optical cables in sfp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62adb14a-103d-4d29-9ecc-96203468e447@solid-run.com>
Date: Thu, 10 Aug 2023 13:38:13 +0200
From: Josua Mayer <josua@...id-run.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net: sfp: handle 100G/25G active optical cables in
 sfp_parse_support

Hi Russell,

Am 10.08.23 um 12:39 schrieb Russell King (Oracle):
> On Thu, Aug 10, 2023 at 11:48:17AM +0200, Josua Mayer wrote:
>> Handle extended compliance code 0x1 (SFF8024_ECC_100G_25GAUI_C2M_AOC)
>> for active optical cables supporting 25G and 100G speeds.
> Thanks. I think I would like one extra change:
>
>> +	case SFF8024_ECC_100G_25GAUI_C2M_AOC:
>>   	case SFF8024_ECC_100GBASE_SR4_25GBASE_SR:
>>   		phylink_set(modes, 100000baseSR4_Full);
> Since SFPs are single lane, SR4 doesn't make sense (which requires
> four lanes), and I shouldn't have added it when adding these modes.
> It would be a good idea to drop that, or at least for the
> addition of the SFF8024_ECC_100G_25GAUI_C2M_AOC case.
>
Would it be okay changing 100000baseSR4 to 100000baseSR dropping the "4"?

- Josua Mayer