netdev - Re: [PATCH] net: phy: at803x: Improve hibernation support on start up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36ee0fa9-040a-8f7e-0447-eb3704ab8e11@denx.de>
Date: Thu, 10 Aug 2023 02:49:55 +0200
From: Marek Vasut <marex@...x.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: Wei Fang <wei.fang@....com>, Oleksij Rempel <o.rempel@...gutronix.de>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 Oleksij Rempel <linux@...pel-privat.de>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH] net: phy: at803x: Improve hibernation support on start up

On 8/10/23 00:06, Andrew Lunn wrote:
> On Wed, Aug 09, 2023 at 11:34:19PM +0200, Marek Vasut wrote:
>> On 8/9/23 15:40, Andrew Lunn wrote:
>>>>> Hm.. how about officially defining this PHY as the clock provider and disable
>>>>> PHY automatic hibernation as long as clock is acquired?
>>>>>
>>>> Sorry, I don't know much about the clock provider/consumer, but I think there
>>>> will be more changes if we use clock provider/consume mechanism.
>>>
>>> Less changes is not always best. What happens when a different PHY is
>>> used?
>>
>> Then the system wouldn't be affected by this AR803x specific behavior.
> 
> Do you know it really is specific to the AR803x? Turning the clock off
> seams a reasonable thing to do when saving power, or when there is no
> link partner.

This hibernation behavior seem specific to this PHY, I haven't seen it 
on another PHY connected to the EQoS so far.