netdev - Re: [PATCH net-next 09/15] inet: move inet->transparent to inet->inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 10 Aug 2023 21:45:17 +0800
From: kernel test robot <lkp@...el.com>
To: Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, Simon Horman <simon.horman@...igine.com>,
	Soheil Hassas Yeganeh <soheil@...gle.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 09/15] inet: move inet->transparent to
 inet->inet_flags

Hi Eric,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/inet-introduce-inet-inet_flags/20230810-184815
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230810103927.1705940-10-edumazet%40google.com
patch subject: [PATCH net-next 09/15] inet: move inet->transparent to inet->inet_flags
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230810/202308102127.hRNurJL6-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308102127.hRNurJL6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308102127.hRNurJL6-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/mptcp/sockopt.c: In function 'mptcp_setsockopt_sol_ip_set_transparent':
>> net/mptcp/sockopt.c:689:27: warning: variable 'issk' set but not used [-Wunused-but-set-variable]
     689 |         struct inet_sock *issk;
         |                           ^~~~


vim +/issk +689 net/mptcp/sockopt.c

4f6e14bd19d6de Maxim Galaganov  2021-12-03  684  
c9406a23c1161c Florian Westphal 2021-11-19  685  static int mptcp_setsockopt_sol_ip_set_transparent(struct mptcp_sock *msk, int optname,
c9406a23c1161c Florian Westphal 2021-11-19  686  						   sockptr_t optval, unsigned int optlen)
c9406a23c1161c Florian Westphal 2021-11-19  687  {
c9406a23c1161c Florian Westphal 2021-11-19  688  	struct sock *sk = (struct sock *)msk;
c9406a23c1161c Florian Westphal 2021-11-19 @689  	struct inet_sock *issk;
c9406a23c1161c Florian Westphal 2021-11-19  690  	struct socket *ssock;
c9406a23c1161c Florian Westphal 2021-11-19  691  	int err;
c9406a23c1161c Florian Westphal 2021-11-19  692  
c9406a23c1161c Florian Westphal 2021-11-19  693  	err = ip_setsockopt(sk, SOL_IP, optname, optval, optlen);
c9406a23c1161c Florian Westphal 2021-11-19  694  	if (err != 0)
c9406a23c1161c Florian Westphal 2021-11-19  695  		return err;
c9406a23c1161c Florian Westphal 2021-11-19  696  
c9406a23c1161c Florian Westphal 2021-11-19  697  	lock_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19  698  
c9406a23c1161c Florian Westphal 2021-11-19  699  	ssock = __mptcp_nmpc_socket(msk);
ddb1a072f85870 Paolo Abeni      2023-04-14  700  	if (IS_ERR(ssock)) {
c9406a23c1161c Florian Westphal 2021-11-19  701  		release_sock(sk);
ddb1a072f85870 Paolo Abeni      2023-04-14  702  		return PTR_ERR(ssock);
c9406a23c1161c Florian Westphal 2021-11-19  703  	}
c9406a23c1161c Florian Westphal 2021-11-19  704  
c9406a23c1161c Florian Westphal 2021-11-19  705  	issk = inet_sk(ssock->sk);
c9406a23c1161c Florian Westphal 2021-11-19  706  
c9406a23c1161c Florian Westphal 2021-11-19  707  	switch (optname) {
c9406a23c1161c Florian Westphal 2021-11-19  708  	case IP_FREEBIND:
53912fdfbaf575 Eric Dumazet     2023-08-10  709  		inet_assign_bit(FREEBIND, ssock->sk,
53912fdfbaf575 Eric Dumazet     2023-08-10  710  				inet_test_bit(FREEBIND, sk));
c9406a23c1161c Florian Westphal 2021-11-19  711  		break;
c9406a23c1161c Florian Westphal 2021-11-19  712  	case IP_TRANSPARENT:
ec4704602ed1ff Eric Dumazet     2023-08-10  713  		inet_assign_bit(TRANSPARENT, ssock->sk,
ec4704602ed1ff Eric Dumazet     2023-08-10  714  				inet_test_bit(TRANSPARENT, sk));
c9406a23c1161c Florian Westphal 2021-11-19  715  		break;
c9406a23c1161c Florian Westphal 2021-11-19  716  	default:
c9406a23c1161c Florian Westphal 2021-11-19  717  		release_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19  718  		WARN_ON_ONCE(1);
c9406a23c1161c Florian Westphal 2021-11-19  719  		return -EOPNOTSUPP;
c9406a23c1161c Florian Westphal 2021-11-19  720  	}
c9406a23c1161c Florian Westphal 2021-11-19  721  
c9406a23c1161c Florian Westphal 2021-11-19  722  	sockopt_seq_inc(msk);
c9406a23c1161c Florian Westphal 2021-11-19  723  	release_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19  724  	return 0;
c9406a23c1161c Florian Westphal 2021-11-19  725  }
c9406a23c1161c Florian Westphal 2021-11-19  726  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki