netdev - Re: [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48e4d7b6-d02b-f1c5-26d0-92ff3ca4df2e@arista.com>
Date: Thu, 10 Aug 2023 17:40:36 +0100
From: Dmitry Safonov <dima@...sta.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: David Ahern <dsahern@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 linux-kernel@...r.kernel.org, Andy Lutomirski <luto@...capital.net>,
 Ard Biesheuvel <ardb@...nel.org>, Bob Gilligan <gilligan@...sta.com>,
 Dan Carpenter <error27@...il.com>, David Laight <David.Laight@...lab.com>,
 Dmitry Safonov <0x7f454c46@...il.com>, Donald Cassidy <dcassidy@...hat.com>,
 Eric Biggers <ebiggers@...nel.org>, "Eric W. Biederman"
 <ebiederm@...ssion.com>, Francesco Ruggeri <fruggeri05@...il.com>,
 "Gaillardetz, Dominik" <dgaillar@...na.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
 Ivan Delalande <colona@...sta.com>, Leonard Crestez <cdleonard@...il.com>,
 Salam Noureddine <noureddine@...sta.com>,
 "Tetreault, Francois" <ftetreau@...na.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for
 TCP-AO connections

On 8/10/23 17:36, Eric Dumazet wrote:
> On Thu, Aug 10, 2023 at 6:27 PM Dmitry Safonov <dima@...sta.com> wrote:
>>
>> On 8/8/23 14:43, Eric Dumazet wrote:
>>> On Wed, Aug 2, 2023 at 7:27 PM Dmitry Safonov <dima@...sta.com> wrote:
>> [..]
>>>>
>>>> +bool tcp_ao_ignore_icmp(struct sock *sk, int type, int code)
>>>
>>> const struct sock *sk ?
>>
>> Well, I can't really: atomic64_inc(&ao->counters.dropped_icmp)
> 
> I think we could, because this would still work.
> 
>  struct tcp_ao_info *ao; // This is rw object

Yeah, right, had not enough coffee today.

> ao = rcu_dereference(tcp_sk(sk)->ao_info);
> 
> This helper looks to accept unlocked sockets, so marking them const
> would avoid mistakes in the future.

I see, will make it `const', thanks!

-- 
            Dmitry