netdev - Race over table->data in proc_do_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <B6988E90-0A1E-4B85-BF26-2DAF6D482433@gmail.com>
Date: Wed, 9 Aug 2023 20:30:37 -0400
From: Sishuai Gong <sishuai.system@...il.com>
To: horms@...ge.net.au,
 ja@....bg
Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>,
 lvs-devel@...r.kernel.org
Subject: Race over table->data in proc_do_sync_threshold()

Hi,

We observed races over (struct ctl_table *) table->data when two threads
are running proc_do_sync_threshold() in parallel, as shown below:

Thread-1			Thread-2
memcpy(val, valp, sizeof(val)); memcpy(valp, val, sizeof(val));

This race probably would mess up table->data. Is it better to add a lock?

Thanks