lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZNUmQKI2bcT98QQ4@vergenet.net> Date: Thu, 10 Aug 2023 20:02:40 +0200 From: Simon Horman <horms@...nel.org> To: Manish Chopra <manishc@...vell.com> Cc: kuba@...nel.org, netdev@...r.kernel.org, aelior@...vell.com, palok@...vell.com, njavali@...vell.com, skashyap@...vell.com, jmeneghi@...hat.com, yuval.mintz@...gic.com, skalluru@...vell.com, pabeni@...hat.com, edumazet@...gle.com, horms@...nel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH v2 net] qede: fix firmware halt over suspend and resume On Wed, Aug 09, 2023 at 07:13:39PM +0530, Manish Chopra wrote: > While performing certain power-off sequences, PCI drivers are > called to suspend and resume their underlying devices through > PCI PM (power management) interface. However this NIC hardware > does not support PCI PM suspend/resume operations so system wide > suspend/resume leads to bad MFW (management firmware) state which > causes various follow-up errors in driver when communicating with > the device/firmware afterwards. > > To fix this driver implements PCI PM suspend handler to indicate > unsupported operation to the PCI subsystem explicitly, thus avoiding > system to go into suspended/standby mode. > > Fixes: 2950219d87b0 ("qede: Add basic network device support") > Cc: David Miller <davem@...emloft.net> > Signed-off-by: Manish Chopra <manishc@...vell.com> > Signed-off-by: Alok Prasad <palok@...vell.com> > --- > V1->V2: > * Replace SIMPLE_DEV_PM_OPS with DEFINE_SIMPLE_DEV_PM_OPS Thanks! Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists