netdev - Re: [PATCH net-next v2] net: dsa: mv88e6060: add phylink_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9zXYx0szwCSGss2+8AaSWr-iDDtiy-+StJUcZxDEht3wQ@mail.gmail.com>
Date: Thu, 10 Aug 2023 21:09:27 +0300
From: Sergei Antonov <saproj@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, 
	Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6060: add phylink_get_caps implementation

On Wed, 9 Aug 2023 at 17:46, Russell King (Oracle)
<rmk+kernel@...linux.org.uk> wrote:
>
> Add a phylink_get_caps implementation for Marvell 88e6060 DSA switch.
> This is a fast ethernet switch, with internal PHYs for ports 0 through
> 4. Port 4 also supports MII, REVMII, REVRMII and SNI. Port 5 supports
> MII, REVMII, REVRMII and SNI without an internal PHY.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
> Sergei,
>
> Would it be possible for you to check that this patch works with your
> setup please?

I have tested it.
First I reverted this commit:
9945c1fb03a3c9f7e0dcf9aa17041a70e551387a net: dsa: fix older DSA
drivers using phylink
So I could see the issue reproduce.
Then I applied this patch and - yes, this patch resolves the issue.

I haven't studied the code carefully, but because of testing:
Tested-by: Sergei Antonov <saproj@...il.com>

Thanks!