netdev - Re: [PATCH net-next v2] net: dsa: mv88e6060: add phylink_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9zcNED55rjnq9a9ZTjp8pCKXWs9HBy5r2KAdECP1Dm8vg@mail.gmail.com>
Date: Thu, 10 Aug 2023 21:17:33 +0300
From: Sergei Antonov <saproj@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, 
	Heiner Kallweit <hkallweit1@...il.com>, Florian Fainelli <f.fainelli@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6060: add phylink_get_caps implementation

On Thu, 10 Aug 2023 at 20:38, Russell King (Oracle)
<linux@...linux.org.uk> wrote:
>
> On Thu, Aug 10, 2023 at 08:11:00PM +0300, Vladimir Oltean wrote:
> > On Thu, Aug 10, 2023 at 05:52:41PM +0100, Russell King (Oracle) wrote:
> > > I wonder whether we have any implementation using SNI mode. I couldn't
> > > find anything in the in-kernel dts files for this driver, the only
> > > dts we have is one that was posted on-list recently, and that was using
> > > MII at 100Mbps:
> > >
> > > https://lore.kernel.org/r/CABikg9zfGVEJsWf7eq=K5oKQozt86LLn-rzMaVmycekXkQEa8Q@mail.gmail.com
> > >
> > > No one would be able to specify "sni" in their dts, so maybe for the
> > > sake of simplicity, we shouldn't detect whether it's in SNI mode, and
> > > just use MII, and limit the speed to just 10Mbps?
> >
> > Based on the fact that "marvell,mv88e6060" is in
> > dsa_switches_apply_workarounds[], it is technically possible that there
> > exist boards which use the SNI mode but have no phy-mode and other
> > phylink properties on the CPU port, and thus they work fine while
> > skipping phylink. Of course, "possible" != "real".
>
> What I meant is that there are no in-tree users of the Marvell 88E6060
> DSA driver. It looks like it was contributed in 2008. Whether it had
> users between the date that it was contributed and today I don't know.
>
> All that I can see is that the only users of it are out-of-tree users,
> which means we have the maintenance burden from the driver but no
> apparent platforms that make use of it, and no way to test it (other
> than if one of those out-of-tree users pops up, such as like last
> month.)

I am planning to submit a platform using "marvell,mv88e6060". For the
next release cycle hopefully.
Our should I rather try to move MV88E6060 support to /mv88e6xxx?